RFR: 8304818: Prune HttpURLConnection cache when corresponding Authenticator is garbage collected [v9]
Michael McMahon
michaelm at openjdk.org
Thu Apr 13 11:36:38 UTC 2023
On Thu, 13 Apr 2023 11:30:15 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> That structure is not related to this change though. Previously, the value added itself to the single static cache, but now to add itself, it needs a reference to the cache instance. We could certainly reorganise this code, but I'm not sure that work belongs in this PR.
>
> Possibly - but there seems to be a lot of churn caused by having to pass an AuthCacheImpl instance to the AuthCacheValue now. It makes it a bit difficult to reason about. I just wonder if *not* passing that value would not simplify the fix considerably. I'll try to import your changes and see what I can find.
Okay, I'll take a look and see if it can be simplified.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13159#discussion_r1165394619
More information about the net-dev
mailing list