RFR: 8304818: Prune HttpURLConnection cache when corresponding Authenticator is garbage collected [v9]
Michael McMahon
michaelm at openjdk.org
Fri Apr 21 21:22:53 UTC 2023
On Thu, 13 Apr 2023 11:33:26 GMT, Michael McMahon <michaelm at openjdk.org> wrote:
>> Possibly - but there seems to be a lot of churn caused by having to pass an AuthCacheImpl instance to the AuthCacheValue now. It makes it a bit difficult to reason about. I just wonder if *not* passing that value would not simplify the fix considerably. I'll try to import your changes and see what I can find.
>
> Okay, I'll take a look and see if it can be simplified. Yes, I can move the caching methods from AuthCacheValue to AuthCacheImpl. I don't think it will simplify this fix as such, but the resulting code is probably more readble.
I've just pushed an update to the implementation which removes the reference to the cache from the `AuthCacheValue`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13159#discussion_r1174170256
More information about the net-dev
mailing list