RFR: 8304818: Prune HttpURLConnection cache when corresponding Authenticator is garbage collected [v13]

[Daniel Jeliński]

On Mon, 24 Apr 2023 14:11:09 GMT, Michael McMahon <michaelm at openjdk.org> wrote:

>> Hi,
>> 
>> Can I get a review for this please? This change uses a Cleaner to check when java.net.Authenticator instances become unreachable, and then prunes the authentication cache for entries that correspond to that Authenticator and therefore cannot be used again. This stops the authentication cache from growing in size unbounded. Note, this only happens in the probably unusual case where more than one Authenticator object is used. Normally there is no reason to use more than one instance.
>> 
>> Thanks,
>> Michael.
>
> Michael McMahon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 20 additional commits since the last revision:
> 
>  - Merge branch 'master' into auth
>  - tests all passing now
>  - tidy up
>  - Merge branch 'master' into auth
>  - update
>  - update
>  - Merge branch 'master' into auth
>  - Update src/java.base/share/classes/sun/net/www/protocol/http/AuthCacheImpl.java
>    
>    Co-authored-by: Daniel Fuchs <67001856+dfuch at users.noreply.github.com>
>  - error in test
>  - Jai's review
>  - ... and 10 more: https://git.openjdk.org/jdk/compare/60bdee78...93a55fe1

Looks good overall. Some files need copyright updates.

src/java.base/share/classes/sun/net/www/protocol/http/NTLMAuthenticationProxy.java line 118:

> 116:     private static NTLMAuthenticationProxy tryLoadNTLMAuthentication() {
> 117:         Class<? extends AuthenticationInfo> cl;
> 118:         Constructor<? extends AuthenticationInfo> fourArg, fiveArg;

Nit: the number of arguments changed again.

-------------

Marked as reviewed by djelinski (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13159#pullrequestreview-1398461196
PR Review Comment: https://git.openjdk.org/jdk/pull/13159#discussion_r1175566657