RFR: 8304818: Prune HttpURLConnection cache when corresponding Authenticator is garbage collected [v13]

[Michael McMahon]

On Mon, 24 Apr 2023 16:29:02 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> Michael McMahon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 20 additional commits since the last revision:
>> 
>>  - Merge branch 'master' into auth
>>  - tests all passing now
>>  - tidy up
>>  - Merge branch 'master' into auth
>>  - update
>>  - update
>>  - Merge branch 'master' into auth
>>  - Update src/java.base/share/classes/sun/net/www/protocol/http/AuthCacheImpl.java
>>    
>>    Co-authored-by: Daniel Fuchs <67001856+dfuch at users.noreply.github.com>
>>  - error in test
>>  - Jai's review
>>  - ... and 10 more: https://git.openjdk.org/jdk/compare/60bdee78...93a55fe1
>
> src/java.base/share/classes/sun/net/www/protocol/http/AuthCacheValue.java line 47:
> 
>> 45:      * The default authentication cache
>> 46:      */
>> 47:     protected static final AuthCacheImpl defCache = new AuthCacheImpl();
> 
> Is this still needed?

Right, that is redundant now as the default instance is created in `AuthCacheImpl`. I will remove it.

> src/java.base/share/classes/sun/net/www/protocol/http/NTLMAuthenticationProxy.java line 118:
> 
>> 116:     private static NTLMAuthenticationProxy tryLoadNTLMAuthentication() {
>> 117:         Class<? extends AuthenticationInfo> cl;
>> 118:         Constructor<? extends AuthenticationInfo> fourArg, fiveArg;
> 
> Nit: the number of arguments changed again.

Yes, I had changed it to threeArgs and fourArgs but missed that method. Will update and check the copyrights

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13159#discussion_r1175566678
PR Review Comment: https://git.openjdk.org/jdk/pull/13159#discussion_r1175569888