RFR: 8313239: InetAddress.getCanonicalHostName may return ip address if reverse lookup fails [v5]

Daniel Fuchs dfuchs at openjdk.org
Thu Aug 3 14:42:32 UTC 2023


On Thu, 3 Aug 2023 12:56:59 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this change which updates the javadoc of `java.net.InetAddress.getCanonicalHostName()` method to clarify its semantics? This addresses https://bugs.openjdk.org/browse/JDK-8313239.
>> 
>> This a javadoc only change and the documentation is updated to match the current implementation. A CSR will be drafted for this change.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   more clarification of the semantics

The updated verbiage looks much better to me.

-------------

Marked as reviewed by dfuchs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15134#pullrequestreview-1561261883


More information about the net-dev mailing list