RFR: 8313239: InetAddress.getCanonicalHostName may return ip address if reverse lookup fails [v5]
Aleksei Efimov
aefimov at openjdk.org
Fri Aug 4 11:14:34 UTC 2023
On Thu, 3 Aug 2023 12:56:59 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Can I please get a review of this change which updates the javadoc of `java.net.InetAddress.getCanonicalHostName()` method to clarify its semantics? This addresses https://bugs.openjdk.org/browse/JDK-8313239.
>>
>> This a javadoc only change and the documentation is updated to match the current implementation. A CSR will be drafted for this change.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>
> more clarification of the semantics
src/java.base/share/classes/java/net/InetAddress.java line 825:
> 823:
> 824: /**
> 825: * Returns the fully qualified domain for this address.
Both `getHostName` and `getCanonicalHostName` talk about `fully qualified domain name`, and how the system-wide resolver is used to determine it. But [InetAddressResolver.lookupByAddress](https://docs.oracle.com/en/java/javase/20/docs/api/java.base/java/net/spi/InetAddressResolver.html#lookupByAddress(byte%5B%5D)) talks about host name, maybe it should be updated to use FQDN term?
`name` is missing here: `fully qualified domain` -> `fully qualified domain name`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15134#discussion_r1284293370
More information about the net-dev
mailing list