RFR: 8300268 : ServerImpl allows too many idle connections when using sun.net.httpserver.maxIdleConnections [v3]

[Jaikiran Pai]

On Tue, 7 Feb 2023 15:40:48 GMT, Darragh Clarke <duke at openjdk.org> wrote:

>> Currently there is a race condition that can allow for too many 'idleConnections' in `ServerImpl`
>> 
>> This PR adds a lock to make sure only one connection can be marked Idle at a time as well as a test that consistently failed before the change but which now passes.
>
> Darragh Clarke has updated the pull request incrementally with one additional commit since the last revision:
> 
>   addressed comments

test/jdk/com/sun/net/httpserver/bugs/8300268/MaxIdleConnectionsTest.java line 130:

> 128:         server.createContext("/MaxIdleConnectionTest/", (exchange) -> {
> 129:             System.out.println("Request " + exchange.getRequestURI()
> 130:                     + " received; handler will wait on latch");

Hello Darragh, this looks like a typo here. This handler implementation doesn't wait on a latch (and instead counts it down). So I think removing the latter part of this log message will avoid any confusion.

-------------

PR: https://git.openjdk.org/jdk/pull/12413