RFR: 8300268 : ServerImpl allows too many idle connections when using sun.net.httpserver.maxIdleConnections [v3]

[Jaikiran Pai]

On Tue, 7 Feb 2023 15:40:48 GMT, Darragh Clarke <duke at openjdk.org> wrote:

>> Currently there is a race condition that can allow for too many 'idleConnections' in `ServerImpl`
>> 
>> This PR adds a lock to make sure only one connection can be marked Idle at a time as well as a test that consistently failed before the change but which now passes.
>
> Darragh Clarke has updated the pull request incrementally with one additional commit since the last revision:
> 
>   addressed comments

A general comment about the new test is that, as far as I am aware, we no longer use the bug id specific test directories. So maybe we should move the new test to the top level under `test/jdk/java/net/httpclient` directory itself. The `HttpServerAccess` test utility class, could perhaps just be a nested class within the test?

Both of these are minor suggestions. If you prefer to use this structure, that's fine with me.

-------------

PR: https://git.openjdk.org/jdk/pull/12413