RFR: 8301701 : java/net/DatagramSocket/DatagramSocketMulticasting.java should be hardened [v4]

[Darragh Clarke]

On Tue, 21 Feb 2023 13:51:04 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> Darragh Clarke has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   reformatted long lines
>
> test/jdk/java/net/DatagramSocket/DatagramSocketMulticasting.java line 260:
> 
>> 258:     static void testTimeToLive(DatagramSocket s) throws IOException {
>> 259:         // should be 1 by default
>> 260:         assertEquals(s.getOption(IP_MULTICAST_TTL), 1);
> 
> Please put the expected value as the first argument to `assertEquals`, otherwise the exception messages may be a bit misleading

Thanks for pointing that out, I'll fix it now

-------------

PR: https://git.openjdk.org/jdk/pull/12513