RFR: 8301701 : java/net/DatagramSocket/DatagramSocketMulticasting.java should be hardened [v4]

Daniel Fuchs dfuchs at openjdk.org
Tue Feb 21 15:05:27 UTC 2023


On Tue, 21 Feb 2023 14:54:00 GMT, Darragh Clarke <duke at openjdk.org> wrote:

>> test/jdk/java/net/DatagramSocket/DatagramSocketMulticasting.java line 260:
>> 
>>> 258:     static void testTimeToLive(DatagramSocket s) throws IOException {
>>> 259:         // should be 1 by default
>>> 260:         assertEquals(s.getOption(IP_MULTICAST_TTL), 1);
>> 
>> Please put the expected value as the first argument to `assertEquals`, otherwise the exception messages may be a bit misleading
>
> Thanks for pointing that out, I'll fix it now

Wait! In Junit the expected value is the second parameter. In TestNG it's the first...

-------------

PR: https://git.openjdk.org/jdk/pull/12513


More information about the net-dev mailing list