RFR: 8295944: Move the Http2TestServer and related classes into a package of its own [v2]

[Jaikiran Pai]

On Tue, 24 Jan 2023 09:59:38 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this change which addresses https://bugs.openjdk.org/browse/JDK-8295944?
>> 
>> As noted in the issue, the HttpClient testing helper infrastructure code resides in a default (unnamed) packages within the test hierarchy. The commit in this PR moves those classes into a specific package. The tests have been updated to refer to them correctly with proper package name references.
>> Additionally as noted in the issue, the `@modules` declaration used in the httpclient tests, were all the same and were repeated in all these tests. The commit in this  PR moves those module references into the `TEST.properties` to centralize such reference. Any test which needs additional modules can then use specific `@modules` declaration in the test definition.
>> 
>> No functional changes have been done in this PR.
>> 
>> tier1, tier2 and tier3 testing passed after these changes.
>
> Jaikiran Pai has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - merge latest from master branch
>  - fix SANTest which was missed out from the refactoring
>  - move out the @modules declaration from test definition, to TEST.properties
>  - 8295944: Move the Http2TestServer and related classes into a package of its own

Hello Daniel,

> There are a few places where some lines should have been removed but were not. I made some suggestions.

Thank you for catching these. These were genuine issues and were a leftover from my `@modules` removal. I've fixed these now in the updated PR. I went through all the files again and did a search (with a different search term this time) and I think have now covered all these leftovers.

-------------

PR: https://git.openjdk.org/jdk/pull/12160