RFR: 8295944: Move the Http2TestServer and related classes into a package of its own [v2]

Jaikiran Pai jpai at openjdk.org
Wed Jan 25 07:08:05 UTC 2023


On Tue, 24 Jan 2023 12:36:30 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

> Also there are 9 classes that have kept their custom @modules clause because they want to access
>
>           java.base/sun.net.www
>           java.base/sun.net 
>
> I wonder if we should just add these two in TEST.properties - and then remove the @modules from these nine classes as well?

I think that's reasonable. When I changed most of these tests to remove `@modules` from their test definition, my selection of "common" declarations missed out these two declarations. I've now updated the `TEST.properties` to include these and also updated the relevant tests to remove the `@modules` declaration.

After this change, there remains few tests which use only a limited subset of the modules delcared in `TEST.properties`. I have left those tests as-is (for example `CancelledResponse.java`), since it didn't look necessary to remove those `@modules`. Let me know if you prefer otherwise and I'll update them as well.

Local testing with the latest state of the PR passed. I've now triggered a broader testing with these changes.

-------------

PR: https://git.openjdk.org/jdk/pull/12160


More information about the net-dev mailing list