RFR: 8300176: URLEncoder/URLDecoder static fields should be private static final [v2]

Jaikiran Pai jpai at openjdk.org
Fri Jan 27 10:52:17 UTC 2023


On Wed, 25 Jan 2023 14:53:19 GMT, Darragh Clarke <duke at openjdk.org> wrote:

>> Made the `static` fields `private static final`, updated the naming as well to reflect this.
>> 
>> This meant I updated `URLDecoder` to set the `DEFAULT_ENCODING_NAME` itself since it had been previously getting it from `URLEncoder`.
>> 
>> Since these fields are only referenced from inside the classes nothing else needed updated
>
> Darragh Clarke has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - reduced bitset to 128 bits
>  - formatting
>  - implemented feedback from PR

Marked as reviewed by jpai (Reviewer).

-------------

PR: https://git.openjdk.org/jdk/pull/12122


More information about the net-dev mailing list