Integrated: 8300176: URLEncoder/URLDecoder static fields should be private static final

Darragh Clarke duke at openjdk.org
Fri Jan 27 10:55:26 UTC 2023


On Fri, 20 Jan 2023 17:41:55 GMT, Darragh Clarke <duke at openjdk.org> wrote:

> Made the `static` fields `private static final`, updated the naming as well to reflect this.
> 
> This meant I updated `URLDecoder` to set the `DEFAULT_ENCODING_NAME` itself since it had been previously getting it from `URLEncoder`.
> 
> Since these fields are only referenced from inside the classes nothing else needed updated

This pull request has now been integrated.

Changeset: d7aa87fd
Author:    Darragh Clarke <Darragh.clarke at oracle.com>
Committer: Jaikiran Pai <jpai at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/d7aa87fdbdc0f3c5bc6c3a7a9c1b57f25fdaebd1
Stats:     31 lines in 2 files changed: 2 ins; 6 del; 23 mod

8300176: URLEncoder/URLDecoder static fields should be private static final

Reviewed-by: redestad, michaelm, stsypanov, dfuchs, jpai

-------------

PR: https://git.openjdk.org/jdk/pull/12122


More information about the net-dev mailing list