RFR: 8301457: Code in SendPortZero.java is uncommented even after JDK-8236852 was fixed

[Aleksei Efimov]

On Thu, 20 Jul 2023 10:50:17 GMT, Michael McMahon <michaelm at openjdk.org> wrote:

> Hi,
> 
> JDK-8236852 was fixed in 15 and included its own regression test, but a couple of existing tests have code commented out that also test this functionality. One scenario relating to sending to the wildcard address was not addressed and remains commented out.
> 
> Thanks,
> Michael.

The changes look fine to me.
You might want to change the last modification years in both copyright headers.

test/jdk/java/net/DatagramSocket/SendPortZero.java line 88:

> 86:         // wildcard addr w/valid port
> 87:         // Referenced in bug 8236105, but not addressed.
> 88:         // So, this scenario is not tested

Is this scenario planned to be addressed? If there is a bug for that (JDK-8236807?) then it could be mentioned in this comment.

-------------

Marked as reviewed by aefimov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14952#pullrequestreview-1541477947
PR Review Comment: https://git.openjdk.org/jdk/pull/14952#discussion_r1270871142