RFR: 8301457: Code in SendPortZero.java is uncommented even after JDK-8236852 was fixed

Michael McMahon michaelm at openjdk.org
Mon Jul 24 07:52:42 UTC 2023


On Fri, 21 Jul 2023 16:31:19 GMT, Aleksei Efimov <aefimov at openjdk.org> wrote:

>> Hi,
>> 
>> JDK-8236852 was fixed in 15 and included its own regression test, but a couple of existing tests have code commented out that also test this functionality. One scenario relating to sending to the wildcard address was not addressed and remains commented out.
>> 
>> Thanks,
>> Michael.
>
> test/jdk/java/net/DatagramSocket/SendPortZero.java line 88:
> 
>> 86:         // wildcard addr w/valid port
>> 87:         // Referenced in bug 8236105, but not addressed.
>> 88:         // So, this scenario is not tested
> 
> Is this scenario planned to be addressed? If there is a bug for that (JDK-8236807?) then it could be mentioned in this comment.

That bug looks like the same issue. I will add a comment to the code and a note in the bug report about the test.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14952#discussion_r1271878082


More information about the net-dev mailing list