RFR: 8301457: Code in SendPortZero.java is uncommented even after JDK-8236852 was fixed

Michael McMahon michaelm at openjdk.org
Mon Jul 24 07:32:42 UTC 2023


On Fri, 21 Jul 2023 16:39:15 GMT, Mark Sheppard <msheppar at openjdk.org> wrote:

>> Hi,
>> 
>> JDK-8236852 was fixed in 15 and included its own regression test, but a couple of existing tests have code commented out that also test this functionality. One scenario relating to sending to the wildcard address was not addressed and remains commented out.
>> 
>> Thanks,
>> Michael.
>
> test/jdk/java/net/MulticastSocket/SendPortZero.java line 88:
> 
>> 86:         // This scenario is not tested
>> 87:         wildcardValidPkt = new DatagramPacket(buf, 0, buf.length);
>> 88:         wildcardValidPkt.setAddress(wildcardAddr);
> 
> again enabling setup but not enabling a corrsponding test scenario?

Yes, I thought it cleaner to just disable the test in one place.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14952#discussion_r1271858185


More information about the net-dev mailing list