RFR: 8301457: Code in SendPortZero.java is uncommented even after JDK-8236852 was fixed

[Mark Sheppard]

On Thu, 20 Jul 2023 10:50:17 GMT, Michael McMahon <michaelm at openjdk.org> wrote:

> Hi,
> 
> JDK-8236852 was fixed in 15 and included its own regression test, but a couple of existing tests have code commented out that also test this functionality. One scenario relating to sending to the wildcard address was not addressed and remains commented out.
> 
> Thanks,
> Michael.

test/jdk/java/net/DatagramSocket/SendPortZero.java line 90:

> 88:         // So, this scenario is not tested
> 89:         wildcardValidPkt = new DatagramPacket(buf, 0, buf.length);
> 90:         wildcardValidPkt.setAddress(wildcardAddr);

you have enabled setup code, but not enabled its coresponding test scenario. Is that intentional?

test/jdk/java/net/MulticastSocket/SendPortZero.java line 88:

> 86:         // This scenario is not tested
> 87:         wildcardValidPkt = new DatagramPacket(buf, 0, buf.length);
> 88:         wildcardValidPkt.setAddress(wildcardAddr);

again enabling setup but not enabling a corrsponding test scenario?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14952#discussion_r1270876834
PR Review Comment: https://git.openjdk.org/jdk/pull/14952#discussion_r1270877677