RFR: 8309200: java/net/httpclient/ExecutorShutdown fails intermittently, if connection closed during upgrade [v3]

Daniel Fuchs dfuchs at openjdk.org
Fri Jun 2 10:51:24 UTC 2023


> The ExecutorShutdown test has been observed failing intermittently, notably if by misfortune the shutdown sequence causes a connection to get aborted while upgrading. The issue is that the `ConnectionAborter` class that allows to mark the connection as being scheduled for closing before a handle to the connection is actually available isn't forwarding the original exception for which closing the connection was requested. When the connection is eventually closed, a generic `IOException: connection closed locally` is raised at the `SocketTube` level, which unfortunately can race with the original cause. 
> 
> The fix makes it possible to relay the original cause to the place where the IOException is raised, in order to set it as the cause of the new exception.

Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:

  More review feedback

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14251/files
  - new: https://git.openjdk.org/jdk/pull/14251/files/5fb0731e..3d3597ae

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14251&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14251&range=01-02

  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/14251.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14251/head:pull/14251

PR: https://git.openjdk.org/jdk/pull/14251


More information about the net-dev mailing list