RFR: 8309200: java/net/httpclient/ExecutorShutdown fails intermittently, if connection closed during upgrade [v3]

[Jaikiran Pai]

On Fri, 2 Jun 2023 10:51:24 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> The ExecutorShutdown test has been observed failing intermittently, notably if by misfortune the shutdown sequence causes a connection to get aborted while upgrading. The issue is that the `ConnectionAborter` class that allows to mark the connection as being scheduled for closing before a handle to the connection is actually available isn't forwarding the original exception for which closing the connection was requested. When the connection is eventually closed, a generic `IOException: connection closed locally` is raised at the `SocketTube` level, which unfortunately can race with the original cause. 
>> 
>> The fix makes it possible to relay the original cause to the place where the IOException is raised, in order to set it as the cause of the new exception.
>
> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   More review feedback

Thank you Daniel for the update. Looks good to me.

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14251#pullrequestreview-1457120562