RFR: 8305763 : Parsing a URI with an underscore goes through a silent exception, negatively impacting performance

[Daniel Fuchs]

On Tue, 16 May 2023 17:20:08 GMT, Dhamoder Nalla <duke at openjdk.org> wrote:

>>> I will work on addressing this to keep the old behavior unchanged.
>> 
>> Please make sure to run the java/net/URI tests - and when these are successful, tier1, tier2 and tier3.
>
> Thanks @dfuch,  
> I have validated the following tests with the new change.
> 1.  JShell:
>        jshell> new URI("http://foo_bar:8080/").getHost()
>        $1 ==> null
> 
>       jshell> new URI("http://foo_bar:8080/").getPort()
>       $2 ==> -1
>       
>       jshell> new URI("http://foobar:8080/").getHost()
>       $3 ==> "foobar"
>       
>       jshell> new URI("http://foobar:8080/").getPort()
>       $4 ==> 8080
> 2.  all tests under "java/net/URI" passed as expected.
> 3. no failures related my change in tier1, tier2 and tier3 tests.

@dhanalla if you integrate this change I will sponsor it. Alternatively if you'd prefer to wait until after the fork that's fine by me.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13430#issuecomment-1578912063