RFR: 8305763 : Parsing a URI with an underscore goes through a silent exception, negatively impacting performance

[Dhamoder Nalla]

On Tue, 6 Jun 2023 14:49:23 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Thanks @dfuch,  
>> I have validated the following tests with the new change.
>> 1.  JShell:
>>        jshell> new URI("http://foo_bar:8080/").getHost()
>>        $1 ==> null
>> 
>>       jshell> new URI("http://foo_bar:8080/").getPort()
>>       $2 ==> -1
>>       
>>       jshell> new URI("http://foobar:8080/").getHost()
>>       $3 ==> "foobar"
>>       
>>       jshell> new URI("http://foobar:8080/").getPort()
>>       $4 ==> 8080
>> 2.  all tests under "java/net/URI" passed as expected.
>> 3. no failures related my change in tier1, tier2 and tier3 tests.
>
> @dhanalla if you integrate this change I will sponsor it. Alternatively if you'd prefer to wait until after the fork that's fine by me.

@dfuch, Thank you for review and sponsorship.
I submitted for integration.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13430#issuecomment-1579029509