RFR: 8303682: Simplify HttpClient DebugLogger

Jaikiran Pai jpai at openjdk.org
Wed Mar 8 07:48:18 UTC 2023


On Wed, 8 Mar 2023 07:20:27 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> The HttpClient internal DebugLogger could be simplified if its configuration was held in a record. Some of the methods in Utils that return a debug logger could also be simplified/removed. The system property that configures the debug logging could be extended to choose between System.err, System.out, System.Logger, or any of these configurations.
>> Passing -Djdk.internal.httpclient.debug=true still works as before.
>
> src/java.net.http/share/classes/jdk/internal/net/http/common/DebugLogger.java line 59:
> 
>> 57:      *                printed to {@link System#err}
>> 58:      * @param logLevel the level above which messages will be forwarded
>> 59:      *               to an underlying {@link System.Logger}
> 
> Hello Daniel, looking at the code, it appears to me that the documentation of all these three levels should say "the level above or equal to which ..." (i.e. `>=` instead of `>`).

I noticed that certain other parts in this class use the term "at or above". I think we should use the same here.

-------------

PR: https://git.openjdk.org/jdk/pull/12900


More information about the net-dev mailing list