RFR: 8303682: Simplify HttpClient DebugLogger [v2]

Daniel Fuchs dfuchs at openjdk.org
Wed Mar 8 11:29:42 UTC 2023


On Wed, 8 Mar 2023 07:44:58 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> src/java.net.http/share/classes/jdk/internal/net/http/common/DebugLogger.java line 59:
>> 
>>> 57:      *                printed to {@link System#err}
>>> 58:      * @param logLevel the level above which messages will be forwarded
>>> 59:      *               to an underlying {@link System.Logger}
>> 
>> Hello Daniel, looking at the code, it appears to me that the documentation of all these three levels should say "the level above or equal to which ..." (i.e. `>=` instead of `>`).
>
> I noticed that certain other parts in this class use the term "at or above". I think we should use the same here.

done

-------------

PR: https://git.openjdk.org/jdk/pull/12900


More information about the net-dev mailing list