RFR: 8304174: Remove delays from httpserver tests
Jaikiran Pai
jpai at openjdk.org
Wed Mar 15 06:53:18 UTC 2023
On Tue, 14 Mar 2023 19:41:25 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:
> This change improves the running time of many httpserver tests; it removes the one second delay introduced by `delay()` calls, and performs immediate httpserver stop by calling `stop(0)`.
>
> For example, `com/sun/net/httpserver/Test1.java` usually takes 20-30 seconds without this change; with this change it completes in 5-8 seconds.
>
> Tiers 1-3 still green.
Hello Daniel, the changes look good to me. Like you note, I don't see any of these tests relying on the delay of server `stop()` for their tests. It's a bit surprising that a lot of these tests were using those delays, but I guess that's because one test influencing the code in another test.
> For example, com/sun/net/httpserver/Test1.java usually takes 20-30 seconds without this change; with this change it completes in 5-8 seconds.
That's a good improvement.
-------------
Marked as reviewed by jpai (Reviewer).
PR: https://git.openjdk.org/jdk/pull/13028
More information about the net-dev
mailing list