RFR: 8304174: Remove delays from httpserver tests
Mark Sheppard
msheppar at openjdk.org
Wed Mar 15 14:57:22 UTC 2023
On Tue, 14 Mar 2023 19:41:25 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:
> This change improves the running time of many httpserver tests; it removes the one second delay introduced by `delay()` calls, and performs immediate httpserver stop by calling `stop(0)`.
>
> For example, `com/sun/net/httpserver/Test1.java` usually takes 20-30 seconds without this change; with this change it completes in 5-8 seconds.
>
> Tiers 1-3 still green.
>From my observations, typically these delays have been used to provide a level of synchronicity between the main thread and various background processing threads. Thus, allowing background processing to conclude prior to the actual shutdown in the server. For example, if you analyse the HttpServerTest, there exists some potential for race conditions to occur. An influencing factor, in all this, is the load on the test system and the number of threads executing. With these changes there may be some intermittent failures -- so one to watch !!
-------------
PR: https://git.openjdk.org/jdk/pull/13028
More information about the net-dev
mailing list