RFR: 8304286: java/net/SocketOption/OptionsTest.java failing after JDK-8302659 [v3]
Daniel Fuchs
dfuchs at openjdk.org
Mon Mar 20 19:10:39 UTC 2023
On Mon, 20 Mar 2023 19:04:34 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> Daniel Jeliński has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Use NetworkConfiguration
>
> test/lib/jdk/test/lib/NetworkConfiguration.java line 399:
>
>> 397: List<InetAddress> addrList = AccessController.doPrivileged(
>> 398: (PrivilegedAction<List<InetAddress>>) () -> list(nif.getInetAddresses()));
>> 399: for (InetAddress addr : addrList) {
>
> Suggestion:
>
> PrivilegedAction<List<InetAddress>> listaddr = () -> list(nif.getInetAddresses());
> @SuppressWarnings("removal")
> List<InetAddress> addrList = AccessController.doPrivileged(listaddr);
> for (InetAddress addr : addrList) {
(disclaimer: I haven't tried to compile the suggestion above)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13061#discussion_r1142570310
More information about the net-dev
mailing list