RFR: 8304286: java/net/SocketOption/OptionsTest.java failing after JDK-8302659 [v3]

Daniel Jeliński djelinski at openjdk.org
Tue Mar 21 12:20:58 UTC 2023


On Mon, 20 Mar 2023 19:07:58 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> test/lib/jdk/test/lib/NetworkConfiguration.java line 399:
>> 
>>> 397:             List<InetAddress> addrList = AccessController.doPrivileged(
>>> 398:                     (PrivilegedAction<List<InetAddress>>) () -> list(nif.getInetAddresses()));
>>> 399:             for (InetAddress addr : addrList) {
>> 
>> Suggestion:
>> 
>>             PrivilegedAction<List<InetAddress>> listaddr = () -> list(nif.getInetAddresses());
>>             @SuppressWarnings("removal")
>>             List<InetAddress> addrList = AccessController.doPrivileged(listaddr);
>>             for (InetAddress addr : addrList) {
>
> (disclaimer: I haven't tried to compile the suggestion above)

This change was no longer needed after applying permissions globally

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13061#discussion_r1143288690


More information about the net-dev mailing list