RFR: 8304286: java/net/SocketOption/OptionsTest.java failing after JDK-8302659 [v4]

Tue Mar 21 12:32:44 UTC 2023

On Tue, 21 Mar 2023 12:20:38 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> Please review this change that fixes and reenables OptionsTest on Windows.
>> 
>> The test is checking that the values retrieved from getOption match the values set by an earlier call to setOption. The `IP_MULTICAST_IF` option was tested with the first network interface for which `supportsMulticast` returned true. JDK-8302659 changed the network interface iteration order and the test started failing.
>> 
>> The proposed change is to verify if the interface is actually usable for multicasting before using it in set/get test. Test passed on all platforms.
>
> Daniel Jeliński has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Apply permissions globally

Marked as reviewed by dfuchs (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/13061#pullrequestreview-1350333492