RFR: 8304286: java/net/SocketOption/OptionsTest.java failing after JDK-8302659 [v4]
Daniel Jeliński
djelinski at openjdk.org
Tue Mar 21 12:20:38 UTC 2023
> Please review this change that fixes and reenables OptionsTest on Windows.
>
> The test is checking that the values retrieved from getOption match the values set by an earlier call to setOption. The `IP_MULTICAST_IF` option was tested with the first network interface for which `supportsMulticast` returned true. JDK-8302659 changed the network interface iteration order and the test started failing.
>
> The proposed change is to verify if the interface is actually usable for multicasting before using it in set/get test. Test passed on all platforms.
Daniel Jeliński has updated the pull request incrementally with one additional commit since the last revision:
Apply permissions globally
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/13061/files
- new: https://git.openjdk.org/jdk/pull/13061/files/4c3525e7..beff55eb
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=13061&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=13061&range=02-03
Stats: 16 lines in 3 files changed: 0 ins; 13 del; 3 mod
Patch: https://git.openjdk.org/jdk/pull/13061.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/13061/head:pull/13061
PR: https://git.openjdk.org/jdk/pull/13061
More information about the net-dev
mailing list