RFR: 8262294: java/net/httpclient/ProxyAuthDisabledSchemes.java fails with HTTP/1.1 parser received no bytes

[Jaikiran Pai]

On Wed, 29 Mar 2023 10:45:22 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

> Please review this trivial fix for setting "Expect" header.
> 
> The original code added a new header every time. As a result, when the request was retried, it was sent with two Expect headers.
> The new code replaces the original Expect header instead of adding a new one.
> 
> Expect header allows only one value, "100-continue", so there's no risk of overwriting some other value.
> 
> No new test. I added the bug ID to the test that was intermittently failing because of this issue. Existing tests continue to pass.
> 
> Also fixed an unintentional passthrough in `switch` case that generated duplicate logs in tests.

Hello Daniel, the changes look good to me. However, looking at the linked JBS, it appears to me that, that JBS is tracking an intermittent failure which causes it to fail with:


java.lang.RuntimeException: Unexpected exception: java.io.IOException: HTTP/1.1 header parser received no bytes 

Additionally, in a recent run the same test failed with a different exception:


java.io.IOException: Expect: [100-Continue, 100-Continue] 

This PR fixes this second exception, but the other intermittent failure would still be present. Is that right? If so, should we instead create and use a different JBS issue to fix this `Expect` header issue, so that the original JBS stays open?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13224#issuecomment-1488456848