RFR: 8262294: java/net/httpclient/ProxyAuthDisabledSchemes.java fails with HTTP/1.1 parser received no bytes

[Jaikiran Pai]

On Wed, 29 Mar 2023 10:45:22 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

> Please review this trivial fix for setting "Expect" header.
> 
> The original code added a new header every time. As a result, when the request was retried, it was sent with two Expect headers.
> The new code replaces the original Expect header instead of adding a new one.
> 
> Expect header allows only one value, "100-continue", so there's no risk of overwriting some other value.
> 
> No new test. I added the bug ID to the test that was intermittently failing because of this issue. Existing tests continue to pass.
> 
> Also fixed an unintentional passthrough in `switch` case that generated duplicate logs in tests.

Marked as reviewed by jpai (Reviewer).

Daniel pointed to me that the double `Expect` header does in fact lead to the same exception that is reported in this JBS issue. I had missed that in the JBS comment.

So this fix isn't really for a different problem. Using the current JBS issue would be the right thing to do.

-------------

PR Review: https://git.openjdk.org/jdk/pull/13224#pullrequestreview-1362929138
PR Comment: https://git.openjdk.org/jdk/pull/13224#issuecomment-1488475098