RFR: 8317295: ResponseSubscribers.SubscriberAdapter should call the finisher function asynchronously [v3]

Daniel Jeliński djelinski at openjdk.org
Mon Oct 2 12:41:18 UTC 2023


On Fri, 29 Sep 2023 11:07:06 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> The finisher function supplied to `BodySubscribers.fromSubscriber` is specified to be called when `onComplete()` is called on the `BodySubscriber`. However, this function contains application code that may involve blocking operations. Though this is technically a user error to block in any function supplied to the HttpClient API, the `ResponseSubscribers.SubscriberAdapter` should protect itself against this by calling the finisher asynchronously, in the fork join pool.
>
> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update @bug

LGTM.

-------------

Marked as reviewed by djelinski (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15981#pullrequestreview-1652656256


More information about the net-dev mailing list