Integrated: 8317295: ResponseSubscribers.SubscriberAdapter should call the finisher function asynchronously
Daniel Fuchs
dfuchs at openjdk.org
Mon Oct 2 13:09:30 UTC 2023
On Fri, 29 Sep 2023 09:47:07 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
> The finisher function supplied to `BodySubscribers.fromSubscriber` is specified to be called when `onComplete()` is called on the `BodySubscriber`. However, this function contains application code that may involve blocking operations. Though this is technically a user error to block in any function supplied to the HttpClient API, the `ResponseSubscribers.SubscriberAdapter` should protect itself against this by calling the finisher asynchronously, in the fork join pool.
This pull request has now been integrated.
Changeset: 8093563b
Author: Daniel Fuchs <dfuchs at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/8093563bce03b2a7dcea175f1e71cfd67de1c235
Stats: 73 lines in 2 files changed: 61 ins; 0 del; 12 mod
8317295: ResponseSubscribers.SubscriberAdapter should call the finisher function asynchronously
Reviewed-by: djelinski
-------------
PR: https://git.openjdk.org/jdk/pull/15981
More information about the net-dev
mailing list