RFR: 8329733: Update the documentation in java.net.SocketOptions to direct to java.net.StandardSocketOptions [v2]

[Jaikiran Pai]

On Fri, 5 Apr 2024 10:22:24 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - "timeout value" instead of "timeout"
>>  - missed SO_TIMEOUT review suggestion in previous commit
>>  - Alan's review suggestions
>
> src/java.base/share/classes/java/net/SocketOptions.java line 37:
> 
>> 35:  * <P>
>> 36:  * The methods and constants defined in this interface are
>> 37:  * for internal implementation use only. If you're not subclassing {@code SocketImpl} or
> 
> I don't think we can insert the word "internal" here it's part of the exposed interface for this legacy mechanism.

I've now updated the PR to remove the "internal" word that was introduced as part of this change.

> src/java.base/share/classes/java/net/SocketOptions.java line 168:
> 
>> 166: 
>> 167:     /**
>> 168:      * Set the outgoing interface on which to send multicast packets. Useful on hosts with
> 
> This option is used to both set and get the outgoing network interface.

Updated the PR to state it can be used to both set and get the interface.

> src/java.base/share/classes/java/net/SocketOptions.java line 199:
> 
>> 197: 
>> 198:     /**
>> 199:      * Set a timeout on blocking {@code Socket} operations:
> 
> This option is also used to set and get the timeout value.

Done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18645#discussion_r1553480930
PR Review Comment: https://git.openjdk.org/jdk/pull/18645#discussion_r1553481472
PR Review Comment: https://git.openjdk.org/jdk/pull/18645#discussion_r1553487255