RFR: 8336817: DatagramSocket.connect does not specify behavior when already connected [v2]

Alan Bateman alanb at openjdk.org
Wed Aug 14 13:02:50 UTC 2024


On Wed, 14 Aug 2024 11:25:02 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this doc-only change which updates the javadoc on several methods of the `java.net.DatagramSocket` class to match its current implementation?
>> 
>> This addresses https://bugs.openjdk.org/browse/JDK-8336817.
>> 
>> I'll open a CSR once we settle on the proposed text.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Alan's suggestion

src/java.base/share/classes/java/net/DatagramSocket.java line 426:

> 424:      *
> 425:      * <p> If this socket is already connected, then this method will attempt to
> 426:      * connect to the passed address and if the connect fails then the state of

A small suggestion is to say "given address" rather than "passed address" and I think break at this point so that "If this connect fails ..." is a new sentence.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20543#discussion_r1716884129


More information about the net-dev mailing list