RFR: 8336817: DatagramSocket.connect does not specify behavior when already connected [v2]

Jaikiran Pai jpai at openjdk.org
Wed Aug 14 13:12:05 UTC 2024


On Wed, 14 Aug 2024 13:00:21 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Alan's suggestion
>
> src/java.base/share/classes/java/net/DatagramSocket.java line 426:
> 
>> 424:      *
>> 425:      * <p> If this socket is already connected, then this method will attempt to
>> 426:      * connect to the passed address and if the connect fails then the state of
> 
> A small suggestion is to say "given address" rather than "passed address" and I think break at this point so that "If this connect fails ..." is a new sentence.

Done. I've updated the PR with this change. I'll now create the CSR for review.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20543#discussion_r1716897687


More information about the net-dev mailing list