RFR: 8343791: Socket.connect API should document whether the socket will be closed when hostname resolution fails or another error occurs [v27]

[Volkan Yazıcı]

On Mon, 2 Dec 2024 08:12:32 GMT, Volkan Yazıcı <duke at openjdk.org> wrote:

>> This PR, addressing 8343791, changes `Socket::connect()` methods to close the `Socket` in the event that the connection cannot be established, the timeout expires before the connection is established, or the socket address is unresolved.
>> 
>> `tier3` tests pass against the 9f00f61d3b7fa42a5e23a04f80bb4bb1a2076ef2.
>
> Volkan Yazıcı has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Reword the `ConnectFailTest` summary

`tier1..3` tests pass – commented on the ticket with a link to the associated the CI run.

Alan's approval is invalidated due to the last `ConnectFailTest` summary change I pushed upon his request. @AlanBateman, @dfuch, I would appreciate it if you can take time for one last (hopefully final) approval, please.

> I think this change looks good now. I'm sure the many iterations were frustrating but I think it has all worked out, and the test is significantly simpler and easy to maintain when compared to where it started.

Indeed the result is objectively way better compared to the initial proposal. :star_struck: Thank you all so much for the guidance. 🙇 I'm sorry for the frustration I caused – I will do my best to minimize it with every new PR. 😅 😇

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22160#issuecomment-2510857908