RFR: 8343791: Socket.connect API should document whether the socket will be closed when hostname resolution fails or another error occurs [v27]

Alan Bateman alanb at openjdk.org
Mon Dec 2 11:06:45 UTC 2024


On Mon, 2 Dec 2024 08:12:32 GMT, Volkan Yazıcı <duke at openjdk.org> wrote:

>> This PR, addressing 8343791, changes `Socket::connect()` methods to close the `Socket` in the event that the connection cannot be established, the timeout expires before the connection is established, or the socket address is unresolved.
>> 
>> `tier3` tests pass against the 9f00f61d3b7fa42a5e23a04f80bb4bb1a2076ef2.
>
> Volkan Yazıcı has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Reword the `ConnectFailTest` summary

The CSR should be finalized as that will need to be approved before the change can be integrated.

-------------

Marked as reviewed by alanb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22160#pullrequestreview-2472395119


More information about the net-dev mailing list