RFR: 8336815: Socket.bind/connect and ServerSocket.bind/accept do not specify behavior when already bound, connected or closed [v4]
Jaikiran Pai
jpai at openjdk.org
Sat Jul 20 16:49:09 UTC 2024
> Can I please get a review of this change which updates the specification of a few methods in `java.net.Socket` and `java.net.ServerSocket` classes to specify the `IOException` that the implementation currently already throws?
>
> This is merely a doc update and doesn't change the implementation.
>
> Given that these exceptions can now be asserted, a new jtreg test has been introduced to verify the exceptions thrown from these APIs. The test passes. tier testing is currently in progress. I'll open a CSR shortly.
Jaikiran Pai has updated the pull request incrementally with two additional commits since the last revision:
- reduce usage of "if" in the throws clause
- simplify the test
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/20268/files
- new: https://git.openjdk.org/jdk/pull/20268/files/957fa7ec..079c5f36
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=20268&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=20268&range=02-03
Stats: 459 lines in 4 files changed: 126 ins; 252 del; 81 mod
Patch: https://git.openjdk.org/jdk/pull/20268.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/20268/head:pull/20268
PR: https://git.openjdk.org/jdk/pull/20268
More information about the net-dev
mailing list