RFR: 8336815: Socket.bind/connect and ServerSocket.bind/accept do not specify behavior when already bound, connected or closed [v4]

Alan Bateman alanb at openjdk.org
Sun Jul 21 06:42:40 UTC 2024


On Sat, 20 Jul 2024 16:49:09 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this change which updates the specification of a few methods in `java.net.Socket` and `java.net.ServerSocket` classes to specify the `IOException` that the implementation currently already throws?
>> 
>> This is merely a doc update and doesn't change the implementation.
>> 
>> Given that these exceptions can now be asserted, a new jtreg test has been introduced to verify the exceptions thrown from these APIs. The test passes. tier testing is currently in progress. I'll open a CSR shortly.
>
> Jaikiran Pai has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - reduce usage of "if" in the throws clause
>  - simplify the test

The spec updates and test look okay to me.

-------------

Marked as reviewed by alanb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20268#pullrequestreview-2190251757


More information about the net-dev mailing list