RFR: 8330814: Cleanups for KeepAliveCache tests [v7]
Christoph Langer
clanger at openjdk.org
Tue May 7 08:43:09 UTC 2024
> While working in that area I found some potential for cleanup of a few tests.
>
> Most notably:
>
> B5045306.java:
> - does not need to run in othervm
> - the executor service that it uses should be shut down eventually to free resources
>
> B8291637.java:
> - use just one instead of two test VM invocations
> KeepAliveTimerThread.java:
> call to grp.destroy() at the end is pointless (API is void & deprecated for removal)
>
> Generally:
> The deprecated URL constructor is used. It can be switched to the handy URIBuilder
> Some more try with resources here and there
Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
- improve code for reading from URLConnection
- Merge branch 'master' into keepalivetests
- Further review suggestions
- Merge branch 'master' into keepalivetests
- Merge branch 'master' into keepalivetests
- Fix two URLs
- Merge branch 'master' into keepalivetests
- Jaikiran's comments
- Update test/jdk/sun/net/www/http/KeepAliveCache/B5045306.java
Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
- Copyright year
- ... and 1 more: https://git.openjdk.org/jdk/compare/a15e5e1d...7ff8a28b
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/18884/files
- new: https://git.openjdk.org/jdk/pull/18884/files/3296795b..7ff8a28b
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=18884&range=06
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=18884&range=05-06
Stats: 7409 lines in 325 files changed: 4004 ins; 1355 del; 2050 mod
Patch: https://git.openjdk.org/jdk/pull/18884.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/18884/head:pull/18884
PR: https://git.openjdk.org/jdk/pull/18884
More information about the net-dev
mailing list