RFR: 8330814: Cleanups for KeepAliveCache tests [v7]

[Daniel Fuchs]

On Tue, 7 May 2024 08:43:09 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> While working in that area I found some potential for cleanup of a few tests.
>> 
>> Most notably:
>> 
>> B5045306.java:
>> - does not need to run in othervm
>> - the executor service that it uses should be shut down eventually to free resources
>> 
>> B8291637.java:
>> - use just one instead of two test VM invocations
>> KeepAliveTimerThread.java:
>> call to grp.destroy() at the end is pointless (API is void & deprecated for removal)
>> 
>> Generally:
>> The deprecated URL constructor is used. It can be switched to the handy URIBuilder
>> Some more try with resources here and there
>
> Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
> 
>  - improve code for reading from URLConnection
>  - Merge branch 'master' into keepalivetests
>  - Further review suggestions
>  - Merge branch 'master' into keepalivetests
>  - Merge branch 'master' into keepalivetests
>  - Fix two URLs
>  - Merge branch 'master' into keepalivetests
>  - Jaikiran's comments
>  - Update test/jdk/sun/net/www/http/KeepAliveCache/B5045306.java
>    
>    Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>  - Copyright year
>  - ... and 1 more: https://git.openjdk.org/jdk/compare/accb250a...7ff8a28b

Looks reasonable. Give us some time to test that in our CI.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18884#pullrequestreview-2043509043