RFR: 8332020: jwebserver tool prints invalid URL in case of IPv6 address binding [v2]
Jaikiran Pai
jpai at openjdk.org
Fri May 10 10:31:44 UTC 2024
> Can I please get a review of this change which proposes to address https://bugs.openjdk.org/browse/JDK-8332020?
>
> `jwebserver` when it is launched prints a URL where the server is accessible. When launched using an IPv6 bind address, the printed URL doesn't enclose the IPv6 literal in `[` `]` thus rendering it in the form:
>
> URL http://0:0:0:0:0:0:0:1:8000/
>
> This is an incorrect representation. As noted in RFC-2732 https://www.rfc-editor.org/rfc/rfc2732#section-2, the host literal is expected to be enclosed between `[` and `]`.
>
> The commit in this PR addresses that issues. A new jtreg test has been introduced to reproduce this issue and verify the fix.
Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
Daniel's suggestion - don't change resource bundle messages
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/19173/files
- new: https://git.openjdk.org/jdk/pull/19173/files/9ab2bc25..4de8c13f
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=19173&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=19173&range=00-01
Stats: 12 lines in 2 files changed: 1 ins; 3 del; 8 mod
Patch: https://git.openjdk.org/jdk/pull/19173.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/19173/head:pull/19173
PR: https://git.openjdk.org/jdk/pull/19173
More information about the net-dev
mailing list