RFR: 8332020: jwebserver tool prints invalid URL in case of IPv6 address binding [v2]

[Daniel Fuchs]

On Fri, 10 May 2024 10:31:44 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this change which proposes to address https://bugs.openjdk.org/browse/JDK-8332020?
>> 
>> `jwebserver` when it is launched prints a URL where the server is accessible. When launched using an IPv6 bind address, the printed URL doesn't enclose the IPv6 literal in `[` `]` thus rendering it in the form:
>> 
>> URL http://0:0:0:0:0:0:0:1:8000/
>> 
>> This is an incorrect representation. As noted in RFC-2732 https://www.rfc-editor.org/rfc/rfc2732#section-2, the host literal is expected to be enclosed between `[` and `]`. 
>> 
>> The commit in this PR addresses that issues. A new jtreg test has been introduced to reproduce this issue and verify the fix.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Daniel's suggestion - don't change resource bundle messages

test/jdk/com/sun/net/httpserver/simpleserver/jwebserver/IPv6BoundHost.java line 56:

> 54:             throw new SkippedException("Skipping test - IPv6 is not supported");
> 55:         }
> 56:         final String output = launchJwebserverAndExit(List.of("-b", "::1"));

Suggestion:

        final String output = launchJwebserverAndExit(List.of("-b", "::1", "-p", "0"));


Let's avoid "Address already in use" ...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19173#discussion_r1596607944