RFR: 8332020: jwebserver tool prints invalid URL in case of IPv6 address binding [v2]

Jaikiran Pai jpai at openjdk.org
Fri May 10 12:02:49 UTC 2024


On Fri, 10 May 2024 10:53:36 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Daniel's suggestion - don't change resource bundle messages
>
> test/jdk/com/sun/net/httpserver/simpleserver/jwebserver/IPv6BoundHost.java line 56:
> 
>> 54:             throw new SkippedException("Skipping test - IPv6 is not supported");
>> 55:         }
>> 56:         final String output = launchJwebserverAndExit(List.of("-b", "::1"));
> 
> Suggestion:
> 
>         final String output = launchJwebserverAndExit(List.of("-b", "::1", "-p", "0"));
> 
> 
> Let's avoid "Address already in use" ...

Good catch. I had forgotten this uses a specific port and not an ephemeral port. I've applied the suggestion. I will run the test in CI.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19173#discussion_r1596664569


More information about the net-dev mailing list