RFR: 8343442: Add since checker tests to the networking area modules [v5]
Daniel Fuchs
dfuchs at openjdk.org
Fri Nov 8 14:29:17 UTC 2024
On Fri, 8 Nov 2024 13:54:43 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:
>> Can I please get a review for this patch that brings the `@since` test described [here](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html) to the networking area modules.
>>
>> The benefit from this is helping API authors and reviewer validate the accuracy of `@since` in their source code (and subsequently, in the generated documentation).
>>
>> The test has been added for `java.base` 2 weeks ago and has helped catch some bugs before they make it to the JDK.
>>
>> Note: the `@modules` declarations are missing from the jtreg comment because we will now include them in a `TEST.properties` file.
>>
>> TIA
>
> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>
> add new test for jdk.sctp, fix @bug id
LGTM
-------------
Marked as reviewed by dfuchs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21838#pullrequestreview-2423952253
More information about the net-dev
mailing list