RFR: 8343442: Add since checker tests to the networking area modules [v5]
Jaikiran Pai
jpai at openjdk.org
Fri Nov 8 14:39:43 UTC 2024
On Fri, 8 Nov 2024 13:54:43 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:
>> Can I please get a review for this patch that brings the `@since` test described [here](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html) to the networking area modules.
>>
>> The benefit from this is helping API authors and reviewer validate the accuracy of `@since` in their source code (and subsequently, in the generated documentation).
>>
>> The test has been added for `java.base` 2 weeks ago and has helped catch some bugs before they make it to the JDK.
>>
>> Note: the `@modules` declarations are missing from the jtreg comment because we will now include them in a `TEST.properties` file.
>>
>> TIA
>
> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>
> add new test for jdk.sctp, fix @bug id
Looks OK to me.
test/jdk/tools/sincechecker/modules/java.net.http/JavaNetHttpCheckSince.java line 27:
> 25: * @test
> 26: * @bug 8343442
> 27: * @summary Test for `@since` in java.net.http module
Hello Nizar, the jtreg tags values in the test definition are regular plain text comments. The use of backtick for `@since` isn't necessary. I don't expect you to go back and change them in this PR, I just noted it for information.
-------------
Marked as reviewed by jpai (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21838#pullrequestreview-2423975831
PR Review Comment: https://git.openjdk.org/jdk/pull/21838#discussion_r1834505016
More information about the net-dev
mailing list