RFR: 8343442: Add since checker tests to the networking area modules [v5]

Nizar Benalla nbenalla at openjdk.org
Fri Nov 8 15:15:23 UTC 2024


On Fri, 8 Nov 2024 14:35:58 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add new test for jdk.sctp, fix @bug id
>
> test/jdk/tools/sincechecker/modules/java.net.http/JavaNetHttpCheckSince.java line 27:
> 
>> 25:  * @test
>> 26:  * @bug 8343442
>> 27:  * @summary Test for `@since` in java.net.http module
> 
> Hello Nizar, the jtreg tags values in the test definition are regular plain text comments. The use of backtick for `@since` isn't necessary. I don't expect you to go back and change them in this PR, I just noted it for information.

Thanks, will keep this in mind for future PRs. I am used to always adding backticks

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21838#discussion_r1834559497


More information about the net-dev mailing list