RFR: 8343791: Socket.connect API should document whether the socket will be closed when hostname resolution fails or another error occurs [v23]

[Daniel Fuchs]

On Fri, 29 Nov 2024 09:11:08 GMT, Volkan Yazıcı <duke at openjdk.org> wrote:

>> This PR, addressing 8343791, changes `Socket::connect()` methods to close the `Socket` in the event that the connection cannot be established, the timeout expires before the connection is established, or the socket address is unresolved.
>> 
>> `tier3` tests pass against the 9f00f61d3b7fa42a5e23a04f80bb4bb1a2076ef2.
>
> Volkan Yazıcı has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - Use more fine-grained suppression
>  - Further simplify tests
>  - Extend `translateToSocketException()` with `AlreadyConnectedException`

Looks fine to me! Please make sure to run tier2 again to double check we haven't upset anything.

-------------

Marked as reviewed by dfuchs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22160#pullrequestreview-2469826752